Open
Conversation
* Add portable CMake test setup * Keep demo builds in CI --------- Co-authored-by: Victor Blomqvist <>
…terative (#1) * Fix stack overflow in cpBBTree by converting recursive functions to iterative Convert all 6 recursive tree traversal functions in cpBBTree.c to iterative implementations using explicit stack arrays, preventing stack overflow when many shapes are added to a space. - SubtreeInsert: while loop with ancestor path tracking - SubtreeQuery: explicit LIFO stack - SubtreeSegmentQuery: explicit LIFO stack with pruning - SubtreeRecycle: explicit LIFO stack - MarkLeafQuery: explicit LIFO stack - MarkSubtree: explicit LIFO stack All functions assert if tree depth exceeds CP_BBTREE_MAX_DEPTH (256), giving a clear error instead of a silent crash. * Use dynamically growing stack for iterative tree traversal Replace fixed-size stack[256] with a growable stack that starts with 64 entries on the C stack and switches to heap allocation when needed. This removes the arbitrary depth limit that would have caused assertion failures with degenerate (fully unbalanced) trees exceeding 256 nodes. Affected functions: SubtreeQuery, SubtreeSegmentQuery, SubtreeRecycle, MarkLeafQuery, MarkSubtree. * Add BBTree stack overflow regression test --------- Co-authored-by: Victor Blomqvist <>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.