Switch to go 1.18#214
Merged
Merged
Conversation
Closed
Contributor
Author
|
I'm waiting on this one before opening other (small) MRs for the changes I proposed in #213 |
Collaborator
|
It says conflict, I fear. |
Go 1.18 is now the the lowest supported version. This is the version that shipped in Ubuntu 22.04 LTS. Update CI to reflect that: test with Go 1.18, Go 1.24 (shipped in Debian 13 "trixie") and Go 'stable' (which is 1.26 at the moment). Update README and drop mentions of Go < 1.11.
I've just run 'go mod tidy' from the golang:1.18 container, here's the result.
Referring to 955a8b2 (from Jan 2019): > The go.mod defines the dependencies and their versions while the vendor > folder contains the vendored deps for pre-1.11 builds. Indeed, when building with Go 1.18, the vendor tree is not used, instead the dependencies are downloaded from the Net, as one can see by simply typing 'make' and watching the output: ``` $ make [...] GO111MODULE=on go build -ldflags "-X github.com/etix/mirrorbits/core.VERSION=v0.6.1-10-g9b08c06 -X github.com/etix/mirrorbits/core.BUILD=9b08c06-switch-to-go-1.18 -X github.com/etix/mirrorbits/config.TEMPLATES_PATH=templates/" -o bin/mirrorbits . go: downloading github.com/op/go-logging v0.0.0-20160315200505-970db520ece7 go: downloading github.com/pkg/errors v0.8.1 go: downloading gopkg.in/yaml.v3 v3.0.1 [...] ``` Given that we don't support Go < 1.18, it's time to remove the vendor tree, it seems.
elboulangero
force-pushed
the
switch-to-go-1.18
branch
from
6f79590 to
205f944
Compare
Contributor
Author
|
Conflict is fixed. I also edited the MR a bit, I realized that I forgot to set |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise the minimum baseline for Go. This is a pre-requisite to move forward with #200