Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
129 changes: 67 additions & 62 deletions modules/vidoomyBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ const buildRequests = (validBidRequests, bidderRequest) => {
usp: bidderRequest.uspConsent || '',
coppa: !!config.getConfig('coppa'),
videoContext: videoContext || '',
multiBidsSupport: 1,
bcat: ortb2.bcat || bid.params.bcat || [],
badv: ortb2.badv || bid.params.badv || [],
bapp: ortb2.bapp || bid.params.bapp || [],
Expand Down Expand Up @@ -203,71 +204,75 @@ const render = (bid) => {

const interpretResponse = (serverResponse, bidRequest) => {
try {
let responseBody = serverResponse.body;
if (!responseBody) return;
if (responseBody.mediaType === 'video') {
responseBody.ad = responseBody.vastUrl || responseBody.vastXml;
const videoContext = bidRequest.data.videoContext;

if (videoContext === OUTSTREAM) {
try {
const renderer = Renderer.install({
id: bidRequest.bidId,
adunitcode: bidRequest.tagId,
loaded: false,
config: responseBody.mediaType,
url: responseBody.meta.rendererUrl
});
renderer.setRender(render);

responseBody.renderer = renderer;
} catch (e) {
responseBody.ad = responseBody.vastUrl || responseBody.vastXml;
logError(BIDDER_CODE + ': error while installing renderer to show outstream ad');
let responseBodies = serverResponse.body;
if (!Array.isArray(responseBodies) || responseBodies.length === 0) return;

const bids = [];

for (let responseBody of responseBodies) {
if (!responseBody) continue;
if (responseBody.mediaType === 'video') {
responseBody.ad = responseBody.vastUrl || responseBody.vastXml;
const videoContext = bidRequest.data.videoContext;

if (videoContext === OUTSTREAM) {
try {
const renderer = Renderer.install({
id: bidRequest.bidId,
adunitcode: bidRequest.tagId,
loaded: false,
config: responseBody.mediaType,
url: responseBody.meta.rendererUrl
});
renderer.setRender(render);

responseBody.renderer = renderer;
} catch (e) {
responseBody.ad = responseBody.vastUrl || responseBody.vastXml;
logError(BIDDER_CODE + ': error while installing renderer to show outstream ad');
}
}
}
}
const bid = {
ad: responseBody.ad,
renderer: responseBody.renderer,
mediaType: responseBody.mediaType,
requestId: responseBody.requestId,
cpm: responseBody.cpm,
currency: responseBody.currency,
width: responseBody.width,
height: responseBody.height,
creativeId: responseBody.creativeId,
netRevenue: responseBody.netRevenue,
ttl: responseBody.ttl,
meta: {
mediaType: responseBody.meta.mediaType,
rendererUrl: responseBody.meta.rendererUrl,
advertiserDomains: responseBody.meta.advertiserDomains,
advertiserId: responseBody.meta.advertiserId,
advertiserName: responseBody.meta.advertiserName,
agencyId: responseBody.meta.agencyId,
agencyName: responseBody.meta.agencyName,
brandId: responseBody.meta.brandId,
brandName: responseBody.meta.brandName,
dchain: responseBody.meta.dchain,
networkId: responseBody.meta.networkId,
networkName: responseBody.meta.networkName,
primaryCatId: responseBody.meta.primaryCatId,
secondaryCatIds: responseBody.meta.secondaryCatIds
const bid = {
ad: responseBody.ad,
renderer: responseBody.renderer,
mediaType: responseBody.mediaType,
requestId: responseBody.requestId,
cpm: responseBody.cpm,
currency: responseBody.currency,
width: responseBody.width,
height: responseBody.height,
creativeId: responseBody.creativeId,
netRevenue: responseBody.netRevenue,
ttl: responseBody.ttl,
meta: {
mediaType: responseBody.meta.mediaType,
rendererUrl: responseBody.meta.rendererUrl,
advertiserDomains: responseBody.meta.advertiserDomains,
advertiserId: responseBody.meta.advertiserId,
advertiserName: responseBody.meta.advertiserName,
agencyId: responseBody.meta.agencyId,
agencyName: responseBody.meta.agencyName,
brandId: responseBody.meta.brandId,
brandName: responseBody.meta.brandName,
dchain: responseBody.meta.dchain,
networkId: responseBody.meta.networkId,
networkName: responseBody.meta.networkName,
primaryCatId: responseBody.meta.primaryCatId,
secondaryCatIds: responseBody.meta.secondaryCatIds
}
};
if (responseBody.vastUrl) {
bid.vastUrl = responseBody.vastUrl;
} else if (responseBody.vastXml) {
bid.vastXml = responseBody.vastXml;
}
};
if (responseBody.vastUrl) {
bid.vastUrl = responseBody.vastUrl;
} else if (responseBody.vastXml) {
bid.vastXml = responseBody.vastXml;
}

const bids = [];

if (isBidResponseValid(bid)) {
bids.push(bid);
} else {
logError(BIDDER_CODE + ': server returns invalid response');
if (isBidResponseValid(bid)) {
bids.push(bid);
} else {
logError(BIDDER_CODE + ': server returns invalid response');
}
}

return bids;
Expand All @@ -280,7 +285,7 @@ const interpretResponse = (serverResponse, bidRequest) => {
function getUserSyncs(syncOptions, responses, gdprConsent, uspConsent) {
if (syncOptions.iframeEnabled || syncOptions.pixelEnabled) {
const pixelType = syncOptions.pixelEnabled ? 'image' : 'iframe';
const urls = deepAccess(responses, '0.body.pixels') || COOKIE_SYNC_FALLBACK_URLS;
const urls = deepAccess(responses, '0.body.0.pixels') || COOKIE_SYNC_FALLBACK_URLS;

return [].concat(urls).map(url => ({
type: pixelType,
Expand Down
12 changes: 6 additions & 6 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

90 changes: 81 additions & 9 deletions test/spec/modules/vidoomyBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,11 @@ describe('vidoomyBidAdapter', function() {
expect('' + request[1].data.pid).to.equal('456456');
});

it('should send multiBidsSupport parameters', function () {
expect('' + request[0].data.multiBidsSupport).to.equal('1');
expect('' + request[1].data.multiBidsSupport).to.equal('1');
});

it('should send schain parameter in serialized form', function () {
const serializedForm = '1.0,1!exchange1.com,1234%21abcd,1,bid-request-1,publisher%2C%20Inc.,publisher.com!exchange2.com,abcd,1,,,!exchange2.com,abcd,1,bid-request-2,intermediary,intermediary.com'
expect(request[0].data).to.include.any.keys('schain');
Expand Down Expand Up @@ -270,7 +275,7 @@ describe('vidoomyBidAdapter', function() {

describe('interpretResponse', function () {
const serverResponseVideo = {
body: {
body: [{
'vastUrl': 'https:\/\/vpaid.vidoomy.com\/demo-ad\/tag.xml',
'mediaType': 'video',
'requestId': '123123',
Expand Down Expand Up @@ -298,11 +303,40 @@ describe('vidoomyBidAdapter', function() {
'primaryCatId': 'IAB3-1',
'secondaryCatIds': null
}
}
},
{
'vastUrl': 'https:\/\/vpaid.vidoomy.com\/demo-ad-two\/tag.xml',
'mediaType': 'video',
'requestId': '102030',
'cpm': 5.265,
'currency': 'USD',
'width': 10,
'height': 400,
'creativeId': '112233',
'dealId': '23cb20aa264b72c',
'netRevenue': true,
'ttl': 80,
'meta': {
'mediaType': 'video',
'rendererUrl': 'https:\/\/vpaid.vidoomy.com\/outstreamplayer\/bundle.js',
'advertiserDomains': ['vidoomy.com'],
'advertiserId': 123,
'advertiserName': 'Vidoomy',
'agencyId': null,
'agencyName': null,
'brandId': null,
'brandName': null,
'dchain': null,
'networkId': null,
'networkName': null,
'primaryCatId': 'IAB3-1',
'secondaryCatIds': null
}
}]
}

const serverResponseBanner = {
body: {
body: [{
'ad': '<iframe src=\'https:\/\/vidoomy.com\/render\/ad.html\' width=\'300\' height=\'250\' frameborder=\'0\' scrolling=\'no\' marginheight=\'0\' marginwidth=\'0\' topmargin=\'0\' leftmargin=\'0\'><\/iframe>',
'mediaType': 'banner',
'requestId': '123123',
Expand Down Expand Up @@ -330,10 +364,39 @@ describe('vidoomyBidAdapter', function() {
'secondaryCatIds': null
},
'pixels': PIXELS
}
},
{
'ad': '<iframe src=\'https:\/\/vidoomy.com\/render\/ad.html\' width=\'400\' height=\'500\' frameborder=\'0\' scrolling=\'no\' marginheight=\'0\' marginwidth=\'0\' topmargin=\'0\' leftmargin=\'0\'><\/iframe>',
'mediaType': 'banner',
'requestId': '102030',
'cpm': 5.94,
'currency': 'USD',
'width': 350,
'height': 400,
'creativeId': '11223344',
'dealId': '230aa095cea76b',
'netRevenue': true,
'ttl': 60,
'meta': {
'mediaType': 'banner',
'advertiserDomains': ['vidoomy.com'],
'advertiserId': 123,
'advertiserName': 'Vidoomy',
'agencyId': null,
'agencyName': null,
'brandId': null,
'brandName': null,
'dchain': null,
'networkId': null,
'networkName': null,
'primaryCatId': 'IAB3-1',
'secondaryCatIds': null
},
'pixels': PIXELS
}]
}

it('should get the correct bid response for outstream video, with renderer, an url in ad, and same requestId', function () {
it('should get the correct bids responses for outstream video, with renderer, an url in ad, and same requestId', function () {
const bidRequest = {
data: {
videoContext: 'outstream'
Expand All @@ -343,15 +406,24 @@ describe('vidoomyBidAdapter', function() {
let result = spec.interpretResponse(serverResponseVideo, bidRequest);

expect(result[0].renderer).to.not.be.undefined;
expect(result[0].ad).to.equal(serverResponseVideo.body.vastUrl);
expect(result[0].requestId).to.equal(serverResponseVideo.body.requestId);
expect(result[0].ad).to.equal(serverResponseVideo.body[0].vastUrl);
expect(result[1].requestId).to.equal(serverResponseVideo.body[1].requestId);
});

it('should get the correct bids responses for banner with same requestId ', function () {
const bidRequest = {};
let result = spec.interpretResponse(serverResponseBanner, bidRequest);

expect(result[0].requestId).to.equal(serverResponseBanner.body[0].requestId);
expect(result[1].requestId).to.equal(serverResponseBanner.body[1].requestId);
});

it('should get the correct bid response for banner with same requestId', function () {
it('should get the correct bids responses for banner with same creativeId ', function () {
const bidRequest = {};
let result = spec.interpretResponse(serverResponseBanner, bidRequest);

expect(result[0].requestId).to.equal(serverResponseBanner.body.requestId);
expect(result[0].creativeId).to.equal(serverResponseBanner.body[0].creativeId);
expect(result[1].creativeId).to.equal(serverResponseBanner.body[1].creativeId);
});

it('should sync user cookies', function () {
Expand Down