add RenewableContext to automatically create new accessTokens#82
Open
Scarbous wants to merge 1 commit into
Open
add RenewableContext to automatically create new accessTokens#82Scarbous wants to merge 1 commit into
Scarbous wants to merge 1 commit into
Conversation
Author
|
In my opinion, this solution has the least impact on the project. |
Owner
|
Hi @Scarbous Could you give me an example why there's need to this "magic" getter?, the Context class is an DTO so i'd expect less magic code there :) |
Author
|
@vienthuong my aim is to have a context that can renew the token independently. I am aware that a DTO should not contain any logic, but the question for me is where this can be better implemented without rebuilding everything. Übersetzt mit DeepL (https://www.deepl.com/app/?utm_source=ios&utm_medium=app&utm_campaign=share-translation) |
Owner
|
Hi @Scarbous In that case, you can just create a class in your project and do exactly the same class ContextRenewable
{
private Context $originContext;
public function __construct(Context $originContext) {
$this->originContext = $originContext;
}
public function getContext(): Context
{
if (!$this->originContext->accessToken->isExpired()) {
return $this->originContext;
}
$adminClient = new AdminAuthenticator(
new RefreshTokenGrantType($this->originContext->accessToken->refreshToken),
$this->originContext->apiEndpoint
);
$this->originContext = new Context($this->originContext->shopUrl, $adminClient->fetchAccessToken());
return $this->originContext;
}
}
// Usage:
$nonExpiredContext = (new ContextRenewable($context))->getContext(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.