Fix one-click GitHub App: omit hook_attributes (manifest was invalid) (v0.189.0)#317
Merged
Merged
Conversation
…lid (v0.189.0)
The one-click "Create GitHub App" flow always failed with GitHub's "Invalid
GitHub App configuration … 'url' wasn't supplied" (forcing manual creation).
Root cause: the manifest included hook_attributes:{active:false} to turn off
the webhook, but GitHub requires hook_attributes.url whenever the object is
present — so it rejected the manifest, and the missing "url" was the WEBHOOK
url, not our (present) top-level url. Fix: omit hook_attributes entirely = an
App with no webhook, no required url.
Confirmed against GitHub's manifest docs. Test 79/79.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The one-click "Create GitHub App" flow never worked — every attempt failed on GitHub with:
…forcing manual App creation every time (instawp + instapods both hit this). My earlier "cross-site POST redirect" guess was wrong.
The real cause: our manifest sent
hook_attributes: { active: false }to disable the webhook. But per GitHub's manifest docs,hook_attributes.urlis required wheneverhook_attributesis present (even withactive:false). So GitHub rejected the whole manifest — and the "url" it meant was the webhook url, not our top-levelurl(which was present all along).Fix
Omit
hook_attributesentirely. An App with nohook_attributes= no webhook (exactly what we want) and no required webhook url. One line removed fromgithubAppManifest.Testing
scripts/github-per-member-test.cjs— 79/79 (assertion updated: manifest omitshook_attributes+ carries the required top-levelurl).🤖 Generated with Claude Code