fix(chat): reliable self-terminating turns — kill the infinite thinking spinner (v0.192.1)#322
Merged
Merged
Conversation
…ing…" (v0.192.1) v1 delivered chat replies by typing into a warm resident TUI pane; when the pane was reaped or the keystrokes didn't trigger a turn, the message was lost and the UI spun forever (row still 'running'). Replies now go through chatSend: each turn is a clean headless resume seeded with the message as the prompt (reliable, not keystroke injection), self-terminating so `alive` is honest. UI "thinking…" is bounded by real liveness, with Resend on a stalled turn and a busy signal when a prior turn is still generating. chat/start is likewise a headless one-shot. Also adds docs/sdk-chat-runtime-plan.md — the v2 that drives chat via the Claude Agent SDK (canUseTool → the existing gateway) for streaming + a real approval hook. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
vikasprogrammer
force-pushed
the
feat/chat-harden
branch
from
9e9f0c2 to
6fc50c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug (live repro on instapods)
A chat reply landed as a
chat.delivered(45 chars injected into a live pane) but Claude produced no turn, the pane died, and the row stayedrunning— so the UI showed "thinking…" forever. Root cause: v1 drove replies by typing into a warm resident TUI pane, which is racy (pane reaped between turns; injected keystrokes not reliably triggering a turn) and gives the UI no honest liveness signal.The fix (minimal harden — keeps the transcript-driven substrate)
Every chat turn is now a clean, self-terminating governed run instead of a warm-pane keystroke:
TerminalManager.chatSend— a headless in-place resume of the same transcript, seeded with the message as the launch prompt (claude --resume <id> --dangerously-skip-permissions "<msg>"). The message is the prompt (reliably starts a turn), and the run tears down at turn-end soalivereflects reality.chat/startis now a headless one-shot (no lingering warm pane to race).409 busy; the UI keeps the draft and asks the user to resend.session.alive) and is bounded — a genuinely stalled turn shows a Resend instead of spinning.Trade: a cold start per turn (no warm latency). Removed properly by v2.
Governance is unchanged — the PreToolUse gate hook still mediates every effect under
--dangerously-skip-permissions.v2 plan (bundled)
docs/sdk-chat-runtime-plan.md— drive the chat surface via the Claude Agent SDK (query()+includePartialMessages+canUseTool→ the existinggateway.ts) for token streaming and a first-class approval hook, running beside the CLI/tmux runtime. Not started; greenlight before building.Verified
npm run typecheck+ server build +cd web && npm run build✓npm run test:governance→ 68/68 ✓chatSendbranching: unknown→error, empty→error, dead-session→sentwith the row flipped torunning/headless=1/resident=0and the new task ✓🤖 Generated with Claude Code