Skip to content

Comments

Add vike-react-sentry#201

Merged
brillout merged 73 commits intomainfrom
nitedani/vike-react-sentry
Feb 12, 2026
Merged

Add vike-react-sentry#201
brillout merged 73 commits intomainfrom
nitedani/vike-react-sentry

Conversation

@nitedani
Copy link
Member

No description provided.

@brillout
Copy link
Member

@nitedani 👀 Shall I start reviewing this?

@nitedani
Copy link
Member Author

Not yet.

@brillout
Copy link
Member

👍 Let me know if you need anything from my side. (FYI vikejs/vike#2950.)

@brillout
Copy link
Member

I just 1. resolved lock file conflict and 2. aligned tsconfig.json with all other packages. No functional changes.

@nitedani
Copy link
Member Author

nitedani commented Jan 6, 2026

https://github.com/vikejs/vike/blob/a8c7987cf4ae3795359cedb4ed07ee8e64ef8abe/packages/vike/src/shared-server-client/hooks/execHook.ts#L222-L224

Need to add throw err after the line originalError = err for the onHookCall error capture to work.

brillout added a commit to vikejs/vike that referenced this pull request Jan 7, 2026
@brillout
Copy link
Member

brillout commented Jan 7, 2026

Need to add throw err after the line originalError = err for the onHookCall error capture to work.

Done (vikejs/vike#3020) & pre-released as 0.4.250-commit-0d50da9.

@brillout
Copy link
Member

How about we make +sentry async and, instead of passing globalContext to it, the user can call getGlobalContext() (like we did for https://vike.dev/onHookCall).

@copilot do it.

Copy link
Contributor

Copilot AI commented Feb 11, 2026

@brillout I've opened a new pull request, #212, to work on those changes. Once the pull request is ready, I'll request review from you.

@brillout
Copy link
Member

LGTM.

@nitedani I made following changes, let me know if you disagree with something:

@brillout
Copy link
Member

I didn't test my changes but I'm assuming CI green => no breaking changes.

@nitedani
Copy link
Member Author

Okay, all good.


## Example

See [examples/sentry](https://github.com/vikejs/vike-react/tree/main/examples/sentry).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
See [examples/sentry](https://github.com/vikejs/vike-react/tree/main/examples/sentry).
See [examples/sentry](https://github.com/vikejs/vike-react/tree/main/examples/sentry).

@brillout brillout merged commit f94f3ad into main Feb 12, 2026
7 checks passed
@brillout brillout deleted the nitedani/vike-react-sentry branch February 12, 2026 08:19
@brillout
Copy link
Member

Published as vike-react-sentry@0.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants