Skip to content

docs(experiment): close bash-bypass-known-gap + kb_add-via-daemon-works (phase 7)#29

Merged
vilosource merged 1 commit into
developfrom
feature/v2-regression-closure
May 16, 2026
Merged

docs(experiment): close bash-bypass-known-gap + kb_add-via-daemon-works (phase 7)#29
vilosource merged 1 commit into
developfrom
feature/v2-regression-closure

Conversation

@vilosource
Copy link
Copy Markdown
Owner

Phase 7 — the acceptance criterion for issue #1. Final phase of the
v2 privileged-write-channel. Builds on merged Phases 1–6.

What changed

  • experiments/tool-gating/EXPERIMENT.md: bash-bypass-known-gap row
    🐛 KNOWN-FAIL → ✅ closed-by-construction. The brain is bind-mounted
    read-only, so bash > facts.jsonl (and every direct syscall path)
    returns EROFS; the only validated write path is the L4 wire to
    mykbd. Old "Discovered security gap" section → "Gap closure (v2)".
  • New positive scenario kb_add-via-daemon-works (matrix row + .sh)
    — bounds the closure from the other side: the fix must not break
    legitimate writes (the role allows-non-knowledge-writes plays for the
    original gating).
  • bash-bypass-known-gap.sh header: KNOWN-FAIL → permanent regression
    guard (its observe() already self-passes when the bypass fails — no
    logic change).

Faithful reporting — what is and isn't claimed

  • Closure mechanism delivered + repo-verified: mykbd daemon,
    dual-socket capability enforcement, RO-mount topology, client
    switchover. Proven in-repo by
    tests/daemon/{cli-over-daemon,dual-socket,server.scenario,rpc-store}.test.ts.
  • In-kb-spike-harness green flip is gated on ONE deployment step —
    the container applying the v2 RO mount + agent socket per
    docs/v2-container-topology.md §4 (a viloforge-platform action, out
    of mykb-repo scope per parent DESIGN §Scope). EXPERIMENT.md states this
    explicitly; no harness run is faked.

Evidence

Full suite 650/650; lint clean.


v2 privileged-write-channel — series complete (issue #1)

Phase PR Status
1 protocol contract #21 ✅ merged
2 daemon scaffold #22 ✅ merged
3 RpcKnowledgeStore #24 ✅ merged
4 extension switchover #26 ✅ merged
5 CLI switchover #27 ✅ merged
6 dual-socket + topology #28 ✅ merged
7 regression closure this

Strict TDD red→green every slice; full testing pyramid
(unit→integration→contract→scenario); contract amendments made via the
doc's own change process with forcing rationale; two deferrals
(SO_PEERCRED→resolved P6 via dual-socket; L2 Strategy suite→when a 2nd
backend exists) documented in contract §7.1. Closes the architectural
work for #1.

…-works (phase 7)

Phase 7 — the acceptance criterion for issue #1.

- experiments/tool-gating/EXPERIMENT.md: bash-bypass-known-gap matrix
  row 🐛 KNOWN-FAIL → ✅ closed-by-construction (RO brain mount + mykbd
  daemon = EROFS on every direct write path). 'Discovered security gap'
  section → 'Gap closure (v2)' documenting the implemented architecture
  and the in-repo proofs.
- New positive scenario kb_add-via-daemon-works.{matrix row, .sh}: the
  closure must not break legitimate writes — bounds it from the other
  side (the role allows-non-knowledge-writes plays for the original
  gating). Backed in-repo by tests/daemon/cli-over-daemon.scenario.
- bash-bypass-known-gap.sh header rewritten: KNOWN-FAIL → permanent
  regression guard (its observe() already self-passes when the bypass
  fails — no logic change needed).

FAITHFUL REPORTING (not overclaimed): the closure MECHANISM is delivered
and repo-verified (cli-over-daemon, dual-socket, server.scenario,
rpc-store daemon tests). The in-kb-spike-harness green flip is gated on
ONE deployment/harness-wiring step — the container applying the v2 RO
mount + agent socket per docs/v2-container-topology.md §4 (a
viloforge-platform action, out of mykb-repo scope per parent DESIGN
§Scope). EXPERIMENT.md states this explicitly rather than faking a
harness run.

Full suite 650/650; lint clean.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 16, 2026

Warning

Rate limit exceeded

@vilosource has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 54 minutes and 40 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2dc998a9-bb19-40f2-af83-4d87a45a45af

📥 Commits

Reviewing files that changed from the base of the PR and between 9b202ea and f674f56.

📒 Files selected for processing (3)
  • experiments/tool-gating/EXPERIMENT.md
  • experiments/tool-gating/scenarios/bash-bypass-known-gap.sh
  • experiments/tool-gating/scenarios/kb_add-via-daemon-works.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vilosource vilosource merged commit e165a5a into develop May 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant