Skip to content

test(zones): CLI-level coverage for the incoming zone#31

Merged
vilosource merged 1 commit into
developfrom
test/incoming-zone-cli
May 18, 2026
Merged

test(zones): CLI-level coverage for the incoming zone#31
vilosource merged 1 commit into
developfrom
test/incoming-zone-cli

Conversation

@vilosource
Copy link
Copy Markdown
Owner

Follow-up to #30 closing the pyramid gap raised in review: the core (knowledge-store) was covered but nothing exercised the curator's actual path — ShellKBWriter shells kb add ... --zone incoming then a human kb verifys it.

Adds 4 CLI/integration tests through the real cli.js:

  • add --zone incoming persists in zone incoming
  • no --zone still defaults active (decision J2N6eo8S)
  • verify on an incoming entry → active + provenance verified (decision ei2k4oZF)
  • invalid zone exits 1 with no orphan JSONL line (corruption guard)

Full suite 659/659; tsc + eslint + prettier clean. Migration separately validated on a copy of the real ~/.mykb (kb rebuild lossless 2907→2907; schema CHECK gains incoming; end-to-end add/verify/invalid-guard correct).

Closes the pyramid gap on PR #30: knowledge-store had the core
coverage but nothing exercised the curator's actual path —
ShellKBWriter shells `kb add ... --zone incoming` then a human
`kb verify`s it. Adds CLI/integration tests via the real cli.js:
--zone incoming persists incoming; no --zone still defaults active
(J2N6eo8S); verify on incoming -> active + provenance verified
(ei2k4oZF); an invalid zone exits 1 with NO orphan JSONL line.

Full suite 659/659; tsc + eslint + prettier clean. Migration
validated out-of-band on a copy of the real ~/.mykb (kb rebuild
lossless 2907->2907, schema CHECK gains incoming, end-to-end add/
verify/invalid-guard all correct).
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026

Warning

Rate limit exceeded

@vilosource has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 25 minutes and 12 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 502a9e91-bf31-42b8-b911-33b14c0877b7

📥 Commits

Reviewing files that changed from the base of the PR and between ff98fe2 and a0933cd.

📒 Files selected for processing (1)
  • tests/cli/cli.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vilosource vilosource merged commit e15727b into develop May 18, 2026
3 checks passed
@vilosource vilosource deleted the test/incoming-zone-cli branch May 18, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants