Address setchannel announce review feedback#9
Draft
mawroayb-ui wants to merge 1 commit into
Draft
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a helper PR for ElementsProject#8982 addressing Rusty's review comments.\n\nChanges:\n- add a regression test for upgrading a private channel with setchannel announce=true on both peers\n- mark the feature experimental in the setchannel schema/docs and note possible interop concerns\n- change the announce added version to v26.06 in schema metadata\n- add announce to the generated Rust RPC request/response model\n- make the announce=false error message match the unsupported parameter state\n\nValidation:\n- Parsed doc/schemas/setchannel.json and contrib/msggen/msggen/schema.json with PowerShell ConvertFrom-Json\n- Ran git diff --check\n\nI could not run the full CLN test suite locally because this Windows workspace has no C/Rust toolchain or WSL installed.