[issue-89] fix: precision follow-up for C5/C7/C9/C3 (#89)#92
Merged
Conversation
Three audit findings outside the scope of #88: 1. C5/C7 (P1): Should Be Equal As Integers/Numbers/Strings escaped the self-compare (C7) and equal-literal (C5) checks because the guard matched exactly "should be equal". The typed variants are equally tautological. New SHOULD_BE_EQUAL_KEYWORDS set, with library-prefix strip (so BuiltIn.Should Be Equal As Integers also matches). 2. C9 (P2): STARTS:/EQUALS: with an empty prefix is a catch-all (every message starts with ""), accepting any error. New _CATCH_ALL_PREFIX_RE ^(STARTS|EQUALS):\s*$ in the catch-all OR. STARTS: connection stays clean. 3. C3 (P3): a swallow (Run Keyword And Return Status) nested under Run Keyword And Continue On Failure reported C2b (LOW) instead of C3 (HIGH). _swallow_status_unused now unwraps one layer of the soft-assert wrapper via _effective_swallow. Warn On Failure is intentionally excluded (it already forces the test green). The ${status}= assignment stays on the outer call, so unused-status detection remains correct. Closes #89
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
3 tasks
vinicq
added a commit
that referenced
this pull request
Jul 2, 2026
Three audit findings outside the scope of #88: 1. C5/C7 (P1): Should Be Equal As Integers/Numbers/Strings escaped the self-compare (C7) and equal-literal (C5) checks because the guard matched exactly "should be equal". The typed variants are equally tautological. New SHOULD_BE_EQUAL_KEYWORDS set, with library-prefix strip (so BuiltIn.Should Be Equal As Integers also matches). 2. C9 (P2): STARTS:/EQUALS: with an empty prefix is a catch-all (every message starts with ""), accepting any error. New _CATCH_ALL_PREFIX_RE ^(STARTS|EQUALS):\s*$ in the catch-all OR. STARTS: connection stays clean. 3. C3 (P3): a swallow (Run Keyword And Return Status) nested under Run Keyword And Continue On Failure reported C2b (LOW) instead of C3 (HIGH). _swallow_status_unused now unwraps one layer of the soft-assert wrapper via _effective_swallow. Warn On Failure is intentionally excluded (it already forces the test green). The ${status}= assignment stays on the outer call, so unused-status detection remains correct. Closes #89
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit follow-up (#89), precision-first. Replaces auto-closed #91 (base branch was deleted on merge of #90).
Should Be Equal As Integers/Numbers/Stringsnow flagged for self-compare and equal literals.STARTS:/EQUALS:with an empty prefix now flagged as catch-all.Continue On Failurenow reported as C3 (HIGH) instead of C2b.257 tests green. Closes #89