fix: socklen_t initialization#59
Merged
rd235 merged 2 commits intovirtualsquare:masterfrom Dec 23, 2024
Merged
Conversation
Member
|
Thank you. Given that the variable "addr" has not been used, I think it is simpler and safer to delete the addr and len variables and change the accept statement to (this comment applies to the three identical changes). |
rd235
approved these changes
Dec 23, 2024
Member
rd235
left a comment
There was a problem hiding this comment.
Thank you for fixing this "ancient" bug....
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed that sometimes, when you try to connect to a wirefilter cable with vdeterm, the connection hangs. The bug was that on wirefilter the
lenparameter onacceptwas not initialized. As the man page says:This fix the wirefilter bug. I've also found that this bug was present on
vde_routerandvde_autolink, so i fix those too.