fix(widgets): ZoomWidget works with OrthographicView#10202
Merged
Pessimistress merged 4 commits intomasterfrom Apr 11, 2026
Merged
fix(widgets): ZoomWidget works with OrthographicView#10202Pessimistress merged 4 commits intomasterfrom
Pessimistress merged 4 commits intomasterfrom
Conversation
chrisgervang
approved these changes
Apr 11, 2026
| /** Which axes to apply zoom to. One of 'X', 'Y' or 'all'. | ||
| * Only effective if the current view is OrthographicView. | ||
| */ | ||
| zoomAxis?: 'X' | 'Y' | 'all'; |
Collaborator
There was a problem hiding this comment.
I'd prefer lowercase here. Do we capitalize other string APIs?
Collaborator
Author
There was a problem hiding this comment.
Hmm good point... sadly OrthographicController's zoomAxis (since v8) uses uppercase X and Y
Collaborator
There was a problem hiding this comment.
Ah dang, ok better to match in this case
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8f125ea. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

OrthographicView no longer respects
zoomwhenzoomXandzoomYare definedChange List
zoomAxispropNote
Medium Risk
Changes
ZoomWidgetzoom behavior and emitted view state forOrthographicView(including newzoomAxiscontrol and updated transition props), which could affect apps relying on prior zoom semantics.Overview
ZoomWidgetnow detectsOrthographicViewand updates zoom usingzoomX/zoomY(andzoom: [zoomX, zoomY]) instead of onlyzoom, with a newzoomAxisprop to zoom X, Y, or both.The
onZoomcallback is extended to optionally includezoomX/zoomY, and zoom transitions switch to interpolatingzoomX/zoomYwhen applicable. Docs are updated and new widget test utilities/specs validate normal zooming, min/max constraints, and orthographic axis behavior.Reviewed by Cursor Bugbot for commit 8f125ea. Bugbot is set up for automated code reviews on this repo. Configure here.