fix(NB-1574): clear template cache on save#72
Merged
cannycookie merged 1 commit into4.xfrom Mar 23, 2026
Merged
Conversation
When email templates are updated via the UI, the changes now take effect
immediately for subsequent emails. This fix addresses cache invalidation
by clearing three cache layers:
1. Laravel application cache (existing)
2. Compiled Blade view cache (new)
3. PHP OPcache for precompiled files (new)
The issue occurred because even though the template data cache was cleared,
Laravel's compiled Blade views and PHP OPcache retained the old content.
Changes:
- Added Artisan::call('view:clear') to clear compiled Blade views
- Added opcache_reset() to clear PHP OPcache when available
- Added comprehensive regression test to verify cache invalidation
Test results:
- Manual testing via tinker confirms cache is cleared on update
- Updated templates are immediately available for email generation
- No stale content is served after template edits
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears template cache on save to fix stale cached templates (NB-1574)