Add config option to override Express' default request size limit#5
Open
bdcarr wants to merge 2 commits intovitalets:mainfrom
Open
Add config option to override Express' default request size limit#5bdcarr wants to merge 2 commits intovitalets:mainfrom
bdcarr wants to merge 2 commits intovitalets:mainfrom
Conversation
2a7ec1a to
6447e30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I've been using your package to parallelise some test scripts. One of them creates ~300kb of data that needs caching, which resulted in
Error: request entity too large, which I found was coming from Express, which has a default limit of 100kb.This change lets you increase that limit:
With that, caching works in my test.
limitisn't a very helpful name imo, but I couldn't think of something succinct and enlightening so I just copied what it's called inexpress.I published my fork here, just so my team can use it until this PR is accepted, so if you want to try it out, there it is. Immediately after doing that I learned about patch-package. Oh well.