fix(reporter): pass project label colors to HTML reporter#10153
Closed
Jack-sh1 wants to merge 1 commit intovitest-dev:mainfrom
Closed
fix(reporter): pass project label colors to HTML reporter#10153Jack-sh1 wants to merge 1 commit intovitest-dev:mainfrom
Jack-sh1 wants to merge 1 commit intovitest-dev:mainfrom
Conversation
The HTML reporter serialized only project names, discarding the
color config. The static client then returned an empty array for
getResolvedProjectLabels. Now both the metadata and the static
client carry { name, color } objects, matching the live UI behavior.
Closes vitest-dev#10141
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
#10142 fixes it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTML reporter serialized only project names, discarding the color config. The static client then returned an empty array for getResolvedProjectLabels. Now both the metadata and the static client carry { name, color } objects, matching the live UI behavior.
Closes #10141
Description
Description
The HTML reporter only serialized project names as plain strings, discarding the
colorconfig. The static client also returned an empty array forgetResolvedProjectLabels. This caused custom project label colors (defined in vitest config) to not render in the HTML report, even though the live UI displayed them correctly.This PR changes
projectsin the HTML metadata fromstring[]to{ name, color }[], and wires up the static client to return the actual label data.Resolves #10141
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.