Skip to content
This repository was archived by the owner on Mar 8, 2025. It is now read-only.

added support for authenticated redis instances#10

Open
acidtib wants to merge 3 commits intovladfaust:masterfrom
bitstopco:auth
Open

added support for authenticated redis instances#10
acidtib wants to merge 3 commits intovladfaust:masterfrom
bitstopco:auth

Conversation

@acidtib
Copy link
Copy Markdown

@acidtib acidtib commented May 30, 2019

No description provided.

@vladfaust
Copy link
Copy Markdown
Owner

That is questionable. It's QOL increase, of course, but that is also a non-standard thing. IMO it's bad to do stuff implicitly in such low-level drivers. Moreover, it is possible to disable certain Redis commands on the server side, which — with this PR merged and AUTH disabled — would lead to errors.

It's simple to extend the functionality when you need it. I often end up creating a Service::Redis service in my apps which wraps MiniRedis pool and proxies requests to it. It is trivial to add auto-authentication to it.

Alternatively, you can always add a custom initializer, say, new_with_auth to MiniRedis itself.

@acidtib
Copy link
Copy Markdown
Author

acidtib commented Aug 21, 2019

@vladfaust this pull request started, because i was using EDA with redis password protected. Feel free to close the request :)

update auth branch with master
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants