This repository was archived by the owner on Mar 8, 2025. It is now read-only.
added support for authenticated redis instances#10
Open
acidtib wants to merge 3 commits intovladfaust:masterfrom
Open
added support for authenticated redis instances#10acidtib wants to merge 3 commits intovladfaust:masterfrom
acidtib wants to merge 3 commits intovladfaust:masterfrom
Conversation
Owner
|
That is questionable. It's QOL increase, of course, but that is also a non-standard thing. IMO it's bad to do stuff implicitly in such low-level drivers. Moreover, it is possible to disable certain Redis commands on the server side, which — with this PR merged and It's simple to extend the functionality when you need it. I often end up creating a Alternatively, you can always add a custom initializer, say, |
Author
|
@vladfaust this pull request started, because i was using EDA with redis password protected. Feel free to close the request :) |
update local master
update auth branch with master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.