Fix window management: handle AirDrop picker cancellation and clean up source window#24
Open
hrueger wants to merge 1 commit into
Open
Fix window management: handle AirDrop picker cancellation and clean up source window#24hrueger wants to merge 1 commit into
hrueger wants to merge 1 commit into
Conversation
…p source window - Make the sharing source window invisible (borderless, transparent, non-key) - Track sharing completion to distinguish cancellation from success/failure - Observe NSWindow.willCloseNotification to detect picker dismissal without a recipient, exiting cleanly on cancel - Clean up the observer and source window in all code paths Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
|
@hrueger Thanks for your contribution! Could you please provide more details on the steps to reproduce this issue? I can't easily reproduce it by cancelling the AirDrop. Also, before / after screen recordings would be amazing. |
Author
|
Please see the following video. When cancelling the dialog, the hidden window with the shadow stays. Also, you can see in the right terminal (htop) that the process keeps running until I kill it in the left terminal with Ctrl+C. Bildschirmaufnahme.2026-07-05.um.09.32.00.mov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thanks for this cool project. I've been using it, but I found a bug: when cancelling the AirDrop dialog (at least on Tahoe), the process does not exit and I keep seeing a small transparent window with a border. This PR fixes it.
Summary
Note
This PR was generated with Claude Code and should be reviewed with a grain of salt.