Fix compatibility with EMV cards (fixes #10)#30
Open
socram8888 wants to merge 1 commit into
Open
Conversation
The card raises an exception when referencing KeyPair. This commit fixes it by simply using separate private and public key objects.
Owner
|
thanks Hopefully the logic is quite simple so i don't think there will be an issue |
Author
|
Thanks. I purchased these cards from AliExpress, found they were crashing and tried your hypothesis at #10 (comment). You were spot on! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The card raises an exception when referencing
KeyPair. This commit fixes it by simply using separate private and public key objects, and usingKeyPaironly for key generation (which these cards do not support)