Skip to content

Add lazy-loading for extras packages#641

Draft
sjmonson wants to merge 3 commits intomainfrom
feat/lazy_loader
Draft

Add lazy-loading for extras packages#641
sjmonson wants to merge 3 commits intomainfrom
feat/lazy_loader

Conversation

@sjmonson
Copy link
Collaborator

TODO

Summary

Lazy loads extras submodules in order to defer import errors to the time of use.

Details

TODO

Test Plan

Without vLLM:

  1. Run guidellm benchmark run --help and observe no errors
  2. Run uv run guidellm benchmark run --backend vllm_python --model test and observe error with helpful message

With vLLM:

  1. Run guidellm benchmark run --help and observe no errors
  2. Run uv run guidellm benchmark run --backend vllm_python --model test ... and observe successful benchmark
  3. Run tox -re test-e2e and observe that tests pass (Previously they would fail when vLLM was installed due to load times)

Related Issues


  • "I certify that all code in this PR is my own, except as noted below."

Use of AI

  • Includes AI-assisted code completion
  • Includes code generated by an AI application
  • Includes AI-generated tests (NOTE: AI written tests should have a docstring that includes ## WRITTEN BY AI ##)

Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
@mergify
Copy link

mergify bot commented Mar 17, 2026

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @sjmonson.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant