Skip to content

Import utils from sub-submodules#644

Merged
sjmonson merged 1 commit intomainfrom
fix/split_utils
Mar 18, 2026
Merged

Import utils from sub-submodules#644
sjmonson merged 1 commit intomainfrom
fix/split_utils

Conversation

@sjmonson
Copy link
Collaborator

Summary

Prereq for some work on deferring imports. utils are designed to be self-contained anyways so this is a small lift.

Test Plan

As long as all tests pass I think we should be good.


  • "I certify that all code in this PR is my own, except as noted below."

Use of AI

  • Includes AI-assisted code completion
  • Includes code generated by an AI application
  • Includes AI-generated tests (NOTE: AI written tests should have a docstring that includes ## WRITTEN BY AI ##)

Signed-off-by: Samuel Monson <smonson@redhat.com>
Copy link
Collaborator

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks straightforward!

@sjmonson
Copy link
Collaborator Author

sjmonson commented Mar 18, 2026

Tangential to this I've noticed in a few PRs that people don't quite understand the import hierarchy. Probably should codify it in the documentation somewhere, but for now here is a rough draft of what I think we are aiming for:

graph TD
    subgraph "Utils"
        Util[Messaging<br/>...]
    end
    
    subgraph "Extras"
        Extra[vLLM<br/>vision<br/>audio]
    end
    
    Schema
    
    Data
    
    Scheduler
    
    Backends
    
    subgraph "Benchmark"
        Benchmarker[Benchmarker<br/>...]
    end
    
    Benchmark --> Data
    Benchmark --> Scheduler
    Benchmark --> Backends
    Benchmark --> Schema
    Benchmark --> Util
    
    Data --> Schema
    Data --> Extra
    Data --> Util
    
    Scheduler --> Util
    Scheduler --> Schema
    
    Backends --> Util
    Backends --> Schema
    
    Extra --> Util
Loading

@sjmonson sjmonson merged commit 736d942 into main Mar 18, 2026
17 checks passed
@sjmonson sjmonson deleted the fix/split_utils branch March 18, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants