Checks for no valid requests in processed dataset#709
Merged
jaredoconnell merged 4 commits intovllm-project:mainfrom May 5, 2026
Merged
Checks for no valid requests in processed dataset#709jaredoconnell merged 4 commits intovllm-project:mainfrom
jaredoconnell merged 4 commits intovllm-project:mainfrom
Conversation
e0d7641 to
b4424c8
Compare
sjmonson
requested changes
Apr 28, 2026
dbutenhof
reviewed
Apr 29, 2026
sjmonson
requested changes
Apr 29, 2026
Collaborator
sjmonson
left a comment
There was a problem hiding this comment.
See my new comments above.
sjmonson
approved these changes
May 1, 2026
Collaborator
sjmonson
left a comment
There was a problem hiding this comment.
My concerns are resolved. Leaving the comments open that @dbutenhof added to in-case any of those still need to be addressed.
dbutenhof
approved these changes
May 1, 2026
This scenario would previously cause a deadlock on pending. Assisted-by: Cursor AI Signed-off-by: Jared O'Connell <joconnel@redhat.com>
Signed-off-by: Jared O'Connell <joconnel@redhat.com>
Signed-off-by: Jared O'Connell <joconnel@redhat.com>
Signed-off-by: Jared O'Connell <joconnel@redhat.com>
7e4e9aa to
8ce6196
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds warnings and errors so that problems in the datasets are visible, rather than silently failing.
In main, if the dataset isn't processed correctly, GuideLLM deadlocks while the datasets are pending.
Details
Test Plan
Currently, due to the other bugs, this command triggers the problem:
Use of AI
## WRITTEN BY AI ##)