Skip to content

[Feat][Router]: allow healthchecks to be disabled by models#920

Draft
max-wittig wants to merge 2 commits intovllm-project:mainfrom
max-wittig:feat/allow-healthcheck-disable-per-model
Draft

[Feat][Router]: allow healthchecks to be disabled by models#920
max-wittig wants to merge 2 commits intovllm-project:mainfrom
max-wittig:feat/allow-healthcheck-disable-per-model

Conversation

@max-wittig
Copy link
Copy Markdown
Contributor

We want to keep the global healthcheck enabled and just disable it for some models that might involve cost per request


  • Make sure the code changes pass the pre-commit checks.
  • Sign-off your commit by using -s when doing git commit
  • Try to classify PRs for easy understanding of the type of changes, such as [Bugfix], [Feat], and [CI].
Detailed Checklist (Click to Expand)

Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Feat] for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).
  • [Router] for changes to the vllm_router (e.g., routing algorithm, router observability, etc.).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • Pass all linter checks. Please use pre-commit to format your code. See README.md for installation.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Please include sufficient tests to ensure the change is stay correct and robust. This includes both unit tests and integration tests.

DCO and Signed-off-by

When contributing changes to this project, you must agree to the DCO. Commits must include a Signed-off-by: header which certifies agreement with the terms of the DCO.

Using -s with git commit will automatically add this header.

What to Expect for the Reviews

We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the ability to disable health checks for specific static backends via a new --static-healthcheck-disabled CLI flag and a healthcheck_disabled YAML configuration field. The review feedback identifies a missing null check when parsing this new field during dynamic reconfiguration and a potential TypeError in the health check loop if model types are not provided.

Comment thread src/vllm_router/dynamic_config.py Outdated
Comment thread src/vllm_router/service_discovery.py Outdated
Comment thread src/vllm_router/parsers/parser.py
max-wittig and others added 2 commits April 23, 2026 09:33
We want to keep the global healthcheck enabled and just disable it for some models that might involve cost per request

Signed-off-by: Max Wittig <max.wittig@siemens.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Max Wittig <max.wittig@siemens.com>
@max-wittig max-wittig force-pushed the feat/allow-healthcheck-disable-per-model branch from 6fae4da to 4f09509 Compare April 23, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants