Skip to content

[Bugfix] to shared storage not working with dynamic PV provisioning#933

Open
NiccoloTosato wants to merge 4 commits intovllm-project:mainfrom
NiccoloTosato:fix-sharedpvc-7a9ed88-1
Open

[Bugfix] to shared storage not working with dynamic PV provisioning#933
NiccoloTosato wants to merge 4 commits intovllm-project:mainfrom
NiccoloTosato:fix-sharedpvc-7a9ed88-1

Conversation

@NiccoloTosato
Copy link
Copy Markdown

@NiccoloTosato NiccoloTosato commented Apr 27, 2026

This will fix #932

Summary

If shared storage is enabled, change HF_HOME from /data to /data/shared-pvc-storage


Checklist

  • Make sure the code changes pass the pre-commit checks.
  • Sign-off your commit by using -s when doing git commit
  • Try to classify PRs for easy understanding of the type of changes, such as [Bugfix], [Feat], and [CI].

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for shared PVC storage by updating the HF_HOME environment variable across vLLM deployments and Ray clusters. However, several critical issues were identified in the Helm templates. The logic in shared-storage.yaml incorrectly restricts PersistentVolume creation and storageClassName assignment when a storage class is defined, which breaks static provisioning. Additionally, while HF_HOME was updated in ray-cluster.yaml, the corresponding volume mounts for the shared storage are missing in both the head and worker groups, which will lead to runtime failures.

Comment thread helm/templates/shared-storage.yaml Outdated
Comment thread helm/templates/shared-storage.yaml
Comment thread helm/templates/shared-storage.yaml Outdated
Comment thread helm/templates/ray-cluster.yaml Outdated
Comment thread helm/templates/ray-cluster.yaml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: sharedPvcStorage does not support dynamic CSI provisioning (requires hostPath)

1 participant