[Bugfix] to shared storage not working with dynamic PV provisioning#933
Open
NiccoloTosato wants to merge 4 commits intovllm-project:mainfrom
Open
[Bugfix] to shared storage not working with dynamic PV provisioning#933NiccoloTosato wants to merge 4 commits intovllm-project:mainfrom
NiccoloTosato wants to merge 4 commits intovllm-project:mainfrom
Conversation
…o storageClass; set PVC.volumeName then
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for shared PVC storage by updating the HF_HOME environment variable across vLLM deployments and Ray clusters. However, several critical issues were identified in the Helm templates. The logic in shared-storage.yaml incorrectly restricts PersistentVolume creation and storageClassName assignment when a storage class is defined, which breaks static provisioning. Additionally, while HF_HOME was updated in ray-cluster.yaml, the corresponding volume mounts for the shared storage are missing in both the head and worker groups, which will lead to runtime failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix #932
Summary
If shared storage is enabled, change
HF_HOMEfrom/datato/data/shared-pvc-storageChecklist
-swhen doinggit commit[Bugfix],[Feat], and[CI].