Bump chart version from 0.1.10 to 0.1.11#941
Conversation
Signed-off-by: Rui Zhang <51696593+ruizhang0101@users.noreply.github.com>
There was a problem hiding this comment.
Code Review
This pull request increments the Helm chart version from 0.1.10 to 0.1.11. Feedback indicates that the PR title is missing a required classification prefix and the description checklist has not been completed. Additionally, it is recommended to add the missing appVersion field to Chart.yaml to follow best practices for application charts and maintain consistency with the existing comments in the file.
| # to the chart and its templates, including the app version. | ||
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | ||
| version: 0.1.10 | ||
| version: 0.1.11 |
There was a problem hiding this comment.
The pull request title is missing a classification prefix (e.g., [Misc] or [CI/Build]) as required by the repository's contribution guidelines. Additionally, the PR description checklist has not been completed. Please update the PR title and ensure the checklist is filled out to facilitate the review process.
| # to the chart and its templates, including the app version. | ||
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | ||
| version: 0.1.10 | ||
| version: 0.1.11 |
There was a problem hiding this comment.
The Chart.yaml file is missing the appVersion field. For charts of type application, it is a best practice to include this field to track the version of the underlying application being deployed. Furthermore, the comments on lines 15-16 explicitly mention that this version number should be incremented along with the app version, yet the field is absent from the file. Consider adding appVersion: 0.1.11 (or the appropriate application version) to maintain consistency and provide better information to users.
Bump chart version from 0.1.10 to 0.1.11
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
-swhen doinggit commit[Bugfix],[Feat], and[CI].Detailed Checklist (Click to Expand)
Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Feat]for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]for changes to thevllm_router(e.g., routing algorithm, router observability, etc.).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-committo format your code. SeeREADME.mdfor installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:header which certifies agreement with the terms of the DCO.Using
-swithgit commitwill automatically add this header.What to Expect for the Reviews
We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.