Bump chart version to 0.1.11#942
Conversation
Signed-off-by: Rui Zhang <51696593+ruizhang0101@users.noreply.github.com>
There was a problem hiding this comment.
Code Review
This pull request increments the Helm chart version from 0.1.10 to 0.1.11. Feedback was provided to improve production readiness by defining an appVersion, avoiding latest image tags in values.yaml, and ensuring compliance with contribution guidelines regarding PR titles and descriptions.
| # to the chart and its templates, including the app version. | ||
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | ||
| version: 0.1.10 | ||
| version: 0.1.11 |
There was a problem hiding this comment.
While bumping the chart version, please consider the following improvements for a production-ready chart: 1) Define an appVersion in Chart.yaml to track the application version. 2) Avoid latest image tags in values.yaml (e.g., lines 43, 379, 425) to ensure reproducible deployments. 3) Ensure the PR title includes a classification prefix (e.g., [Misc]) and the description checklist is completed as per the contribution guidelines.
Bump chart version to 0.1.11
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
-swhen doinggit commit[Bugfix],[Feat], and[CI].Detailed Checklist (Click to Expand)
Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Feat]for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]for changes to thevllm_router(e.g., routing algorithm, router observability, etc.).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-committo format your code. SeeREADME.mdfor installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:header which certifies agreement with the terms of the DCO.Using
-swithgit commitwill automatically add this header.What to Expect for the Reviews
We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.