[CI/Build] Anchor Chart.yaml version grep to start of line#944
Merged
ruizhang0101 merged 2 commits intovllm-project:mainfrom May 7, 2026
Merged
Conversation
The grep for the chart's own version was matching dependency versions too (kube-prometheus-stack, prometheus-adapter), producing a multi-line value that broke `$GITHUB_OUTPUT` parsing with "Invalid format". Anchor the regex to the start of the line — the chart's top-level version key is the only one at column 0; dependency versions are indented under list items. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Rui Zhang <zrfishnoodles@gmail.com>
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
release-dockerjob was failing withInvalid format '82.4.3'when writing to\$GITHUB_OUTPUT. Example failure: https://github.com/vllm-project/production-stack/actions/runs/25514259997/job/74881416401Root cause
helm/Chart.yamlcontains threeversion:keys: the chart's own version plus two dependencies (kube-prometheus-stack: 82.4.3,prometheus-adapter: 5.3.0). The current grep matches all three, producing a multi-line value. When written asversion=0.1.11\n82.4.3\n5.3.0to\$GITHUB_OUTPUT, GHA parses subsequent lines as freshkey=valuepairs, hence theInvalid format '82.4.3'error.Fix
Anchor the regex to the start of line (
^version:). The chart's top-levelversion:key is at column 0; dependency versions are indented under list items, so the anchor narrows the match to the chart's own version.Same fix applied to
scheduled-release.ymlwhich has the identical pattern.Test plan
\$GITHUB_OUTPUTparsing.grep -oP '^version: ...' helm/Chart.yamlreturns only the chart version.🤖 Generated with Claude Code