feat: update dropdown icons, move last-updated to header with commit link#70
Merged
darcyclarke merged 2 commits intovltpkg:mainfrom Mar 11, 2026
Merged
Conversation
…link ## Icon changes - Tools dropdown: replaced ListFilter (lucide) with Geist terminal-window icon - Fixtures dropdown: replaced Package icon with Geist briefcase icon - New icon components: TerminalWindow, Briefcase (16×16 SVG from Geist icons) ## Last updated + commit hash - Moved 'last updated' date from footer to header, displayed as small text to the right of the 'Benchmarks' title (hidden on mobile to save space) - Added commit SHA link (short 7-char hash) that links to the GitHub commit associated with the benchmark run - generate-chart.js now accepts an optional commit SHA as second argument and includes it as `commitSha` in chart-data.json - process-results.sh passes GITHUB_SHA (or git rev-parse HEAD as fallback) to generate-chart.js - BenchmarkChartData type updated with optional `commitSha` field - Footer simplified: removed date display, kept methodology + theme switcher
Replace custom Geist SVG icons with lucide-react equivalents: - Tools dropdown: Hammer (lucide) instead of custom TerminalWindow - Fixtures dropdown: BriefcaseBusiness (lucide) instead of custom Briefcase - Removed unused briefcase.tsx and terminal-window.tsx icon files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Icon changes
ListFilter(lucide) with Geistterminal-windowiconPackageicon with GeistbriefcaseiconTerminalWindow,Briefcase(16×16 SVG, sourced from Geist Icons)Last updated + commit hash in header
github.com/vltpkg/benchmarks/commit/{sha}Benchmarks · Feb 28, 2026 · abc1234generate-chart.jsaccepts optional commit SHA (2nd arg), emitscommitShainchart-data.jsonprocess-results.shpasses$GITHUB_SHA(withgit rev-parse HEADfallback) to the chart generatorBenchmarkChartDatatype now includes optionalcommitSha: stringFooter cleanup