Skip to content

fix(modules): guard regex extractor against negative group index #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TBX3D wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(modules): guard regex extractor against negative group index #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/modules/executor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,7 @@ func runExtractors(extractors []Extractor, resp *http.Response, body string) map
continue
}
matches := re.FindStringSubmatch(part)
if len(matches) > e.Group {
if e.Group >= 0 && len(matches) > e.Group {
result[e.Name] = matches[e.Group]
break
}
Expand Down
8 changes: 8 additions & 0 deletions internal/modules/matchers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,14 @@ func TestRunExtractors(t *testing.T) {
},
wantNil: true,
},
{
// a negative group must be skipped, not panic on matches[-1].
name: "negative group is skipped",
extractors: []Extractor{
{Type: "regex", Name: "session", Part: "body", Regex: []string{`"session":"([^"]+)"`}, Group: -1},
},
wantNil: true,
},
{
name: "invalid pattern is skipped, no capture",
extractors: []Extractor{
Expand Down
Loading