This repository was archived by the owner on Nov 9, 2020. It is now read-only.
Fixing issue with URI parsing of passwords taken from the command line.#60
Open
codemonkeyjohn wants to merge 3 commits into
Open
Fixing issue with URI parsing of passwords taken from the command line.#60codemonkeyjohn wants to merge 3 commits into
codemonkeyjohn wants to merge 3 commits into
Conversation
Added test cases for parsing URIs in the connect method. It requires mocha to mock the VIM objects for the unit test.
Contributor
Author
|
I've added tests and modified the code to allow domains in usernames, too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The command-line parsing of the uri doesn't allow certain characters (/, ?, @, #, <, or >) to be used:
$ rvc root:tes/ting@vmhost
Failed to parse URI "root:tes/ting@vmhost": bad component(expected user component): test#ng
To get around this, I tried to URI-encode the offending character, but got an InvalidLogin message:
$ rvc root:tes%2fting@vmhost
Failed to connect to vmhost: InvalidLogin: Cannot complete login due to an incorrect user name or password.
This commit decodes the password, so the second command would work.