This repository was archived by the owner on Mar 24, 2022. It is now read-only.
Allow 'minion' to be absent in cloud.profiles entries - fixes #701#893
Open
matthewryanscott wants to merge 1 commit intovmware-archive:developfrom
Open
Allow 'minion' to be absent in cloud.profiles entries - fixes #701#893matthewryanscott wants to merge 1 commit intovmware-archive:developfrom
matthewryanscott wants to merge 1 commit intovmware-archive:developfrom
Conversation
Prior to this patch, you'd get the following traceback if you didn't specify a 'minion' key in an entry in /etc/salt/cloud.profiles:
$ sudo salt-cloud -m /etc/salt/cloud.map
[INFO ] salt-cloud starting
[INFO ] Applying map from '/etc/salt/cloud.map'.
[ERROR ] There was a query error: 'minion'
Traceback (most recent call last):
File "/opt/salt-cloud/src/salt-cloud/saltcloud/cli.py", line 273, in run
dmap = mapper.map_data()
File "/opt/salt-cloud/src/salt-cloud/saltcloud/cloud.py", line 1102, in map_data
if 'grains' in nodedata['minion']:
KeyError: 'minion'
Contributor
|
@s0undt3ch, what are your thoughts on this? |
Contributor
|
Still need to test the provided configuration to see if I reproduce. This fixes the problem but we need to make sure it's not something deeper in the code. |
Contributor
|
@gldnspud, I'm sorry that we didn't get this addressed before we got salt-cloud merged into Salt. Even though it is no longer physically possible to merge code into Salt Cloud from this repo, I'm going to leave this in until we can get it addressed in the new salt.cloud location. If we do end up using this change, we'll be sure to credit you appropriately, of course. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this patch, you'd get the following traceback if you didn't specify a 'minion' key in an entry in /etc/salt/cloud.profiles:
$ sudo salt-cloud -m /etc/salt/cloud.map
[INFO ] salt-cloud starting
[INFO ] Applying map from '/etc/salt/cloud.map'.
[ERROR ] There was a query error: 'minion'
Traceback (most recent call last):
File "/opt/salt-cloud/src/salt-cloud/saltcloud/cli.py", line 273, in run
dmap = mapper.map_data()
File "/opt/salt-cloud/src/salt-cloud/saltcloud/cloud.py", line 1102, in map_data
if 'grains' in nodedata['minion']:
KeyError: 'minion'