This repository was archived by the owner on Feb 17, 2026. It is now read-only.
chore(file): remove "private" comment from clearFiles method#301
Open
kevinbuhmann wants to merge 1 commit into
Open
chore(file): remove "private" comment from clearFiles method#301kevinbuhmann wants to merge 1 commit into
clearFiles method#301kevinbuhmann wants to merge 1 commit into
Conversation
Since the `cds-file` component ignores non-user `change` events, the `clearFiles` method is the only way to programmatically clear the file input.
Thank you, 🤖 Clarity Release Bot |
Jinnie
approved these changes
Apr 12, 2024
Contributor
Jinnie
left a comment
Jinnie
left a comment
There was a problem hiding this comment.
Need to update the public api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the
cds-filecomponent ignores non-userchangeevents, theclearFilesmethod is needed externally to programmatically clear the file input and reset the button label.