Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the PC is paused (e.g., due to a
waitinstruction), and theold_pc_hwvalue is0, the nextpc_hwvalue may wrap backward by 4 bytes (e.g., from0x0to0x3fffc), due to hardware behavior. This inverse wrap was not correctly handled in the code, andpc_offsetremained unchanged.As a result, the program counter (
pc) appeared to advance incorrectly by0x40000, causingpc > mem_offset, and ultimately triggering a memory buffer underrun.Fix
Added the following check in the PC tracking logic to detect and correct inverse wrap-around: