feat: added --disable-size flag and related handling#246
Open
yetanotheraryan wants to merge 1 commit intovoidcosmos:mainfrom
Open
feat: added --disable-size flag and related handling#246yetanotheraryan wants to merge 1 commit intovoidcosmos:mainfrom
yetanotheraryan wants to merge 1 commit intovoidcosmos:mainfrom
Conversation
Member
|
Thanks for opening this PR! I've been reviewing it and found a bug: when The fix should keep calling |
zaldih
requested changes
Apr 13, 2026
Comment on lines
+771
to
+791
| if (this.config.disableSize) { | ||
| this.scanSubscription = scan$.subscribe({ | ||
| next: () => this.printFoldersSection(), | ||
| error: (error) => this.newError(error), | ||
| complete: () => this.completeSearch(), | ||
| }); | ||
| } else { | ||
| this.scanSubscription = scan$ | ||
| .pipe( | ||
| mergeMap( | ||
| (nodeFolder) => this.scanService.calculateFolderStats(nodeFolder), | ||
| 10, // Limit to 10 concurrent stat calculations at a time | ||
| ), | ||
| tap((folder) => this.processFolderStatsForUi(folder)), | ||
| ) | ||
| .subscribe({ | ||
| next: () => this.printFoldersSection(), | ||
| error: (error) => this.newError(error), | ||
| complete: () => this.completeSearch(), | ||
| }); | ||
| } |
Member
There was a problem hiding this comment.
Instead of branching here, keep callng calculateFolderStats always. Move the disableSize check inside that emthod so it skips only the size calculation but still computes modificationTime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #240
Changes
disableSizeto the CLI config interface and default config.--disable-sizeoption in CLI help/options.ResultsUiso result rendering can react todisableSize.calculateFolderStats()whendisableSizeis enabled.--delete-allhandling so folders can be deleted as soon as they are found when size calculation is disabled.disableSizefield.Validation
npm run buildpasses.npm testpasses.node lib/index.js --helpshows--disable-size.Note
--disable-sizecurrently affects interactive UI mode.