Skip to content

fix(cli): wrap zsh completion in eval for dash compatibility #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengmk2 merged 3 commits into from
Apr 3, 2026
Merged

fix(cli): wrap zsh completion in eval for dash compatibility #1280

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a65ff23
fix(cli): wrap zsh completion in eval for dash compatibility
shaneturner Apr 3, 2026
ae71751
Merge branch 'main' into fix/dash-env-compatibility
fengmk2 Apr 3, 2026
d0bb9c3
Merge branch 'main' into fix/dash-env-compatibility
fengmk2 Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions crates/vite_global_cli/src/commands/env/setup.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,13 +449,15 @@ if [ -n "$BASH_VERSION" ] && type complete >/dev/null 2>&1; then
eval "$(VP_COMPLETE=bash command vp)"
elif [ -n "$ZSH_VERSION" ] && type compdef >/dev/null 2>&1; then
eval "$(VP_COMPLETE=zsh command vp)"
eval '
_vpr_complete() {
local -a orig=("${words[@]}")
words=("vp" "run" "${orig[@]:1}")
CURRENT=$((CURRENT + 1))
${=_comps[vp]}
}
compdef _vpr_complete vpr
'
fi
"#
.replace("__VP_BIN__", &bin_path_ref);
Expand Down Expand Up @@ -918,6 +920,10 @@ mod tests {
env_content.contains("compdef _vpr_complete vpr"),
"env should have vpr completion for zsh"
);
assert!(
env_content.contains("eval '") && env_content.contains("_vpr_complete() {"),
"env should wrap zsh-specific code in eval"
);
assert!(fish_content.contains("complete -c vpr"), "env.fish should have vpr completion");
assert!(
ps1_content.contains("Register-ArgumentCompleter -Native -CommandName vpr"),
Expand Down
Loading