fix(cli): scope CI env var to child process in Windows install script#1292
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 6, 2026
Merged
fix(cli): scope CI env var to child process in Windows install script#1292graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Member
Author
|
test works |
cpojer
approved these changes
Apr 6, 2026
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Apr 6, 2026
…#1292) Use `cmd /c "set CI=true && ..."` instead of setting `$env:CI` directly, so the variable is scoped to the child process and does not persist in the user's PowerShell session. This prevented `vp create` from entering interactive mode when run in the same terminal after installation. Closes #1288
graphite-app
bot
force-pushed
the
win-install-issue1288
branch
from
1709b3c to
15d8501
Compare
…#1292) Use `cmd /c "set CI=true && ..."` instead of setting `$env:CI` directly, so the variable is scoped to the child process and does not persist in the user's PowerShell session. This prevented `vp create` from entering interactive mode when run in the same terminal after installation. Closes #1288
fengmk2
force-pushed
the
win-install-issue1288
branch
from
15d8501 to
d7b9b6a
Compare
Member
Author
|
By the way, fix the flaky snap test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
cmd /c "set CI=true && ..."instead of setting$env:CIdirectly,so the variable is scoped to the child process and does not persist in the
user's PowerShell session. This prevented
vp createfrom enteringinteractive mode when run in the same terminal after installation.
Closes #1288