Skip to content

fix(cli): enable cache support for vp check in task runner#1328

Merged
graphite-app[bot] merged 1 commit intomainfrom
vp-check-support-cache
Apr 8, 2026
Merged

fix(cli): enable cache support for vp check in task runner#1328
graphite-app[bot] merged 1 commit intomainfrom
vp-check-support-cache

Conversation

@fengmk2
Copy link
Copy Markdown
Member

@fengmk2 fengmk2 commented Apr 7, 2026

When vp check was used as a script (e.g., "check": "vp check") and
run via vp run check with run: { cache: true }, cache was always
disabled because the command handler forced UserCacheConfig::disabled().

Change the Check handler to use UserCacheConfig::with_config(...) with
auto input tracking and task-cache directory exclusions, matching the
pattern used by other synthesized commands (build, lint, fmt).

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 7, 2026

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit 21c9590
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/69d5bab9882bdc0008fdaf47

@fengmk2 fengmk2 self-assigned this Apr 7, 2026
Copy link
Copy Markdown
Member Author

fengmk2 commented Apr 7, 2026


How to use the Graphite Merge Queue

Add the label auto-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2 fengmk2 force-pushed the vp-check-support-cache branch 5 times, most recently from 2bb54c0 to d08d260 Compare April 7, 2026 14:20
@fengmk2 fengmk2 marked this pull request as ready for review April 7, 2026 14:45
@fengmk2 fengmk2 requested review from branchseer and cpojer April 7, 2026 14:46
@graphite-app
Copy link
Copy Markdown

graphite-app bot commented Apr 8, 2026

Merge activity

graphite-app bot pushed a commit that referenced this pull request Apr 8, 2026
When `vp check` was used as a script (e.g., `"check": "vp check"`) and
run via `vp run check` with `run: { cache: true }`, cache was always
disabled because the command handler forced `UserCacheConfig::disabled()`.

Change the Check handler to use `UserCacheConfig::with_config(...)` with
auto input tracking and task-cache directory exclusions, matching the
pattern used by other synthesized commands (build, lint, fmt).
@graphite-app graphite-app bot force-pushed the vp-check-support-cache branch from 4d34a0d to f257870 Compare April 8, 2026 02:16
When `vp check` was used as a script (e.g., `"check": "vp check"`) and
run via `vp run check` with `run: { cache: true }`, cache was always
disabled because the command handler forced `UserCacheConfig::disabled()`.

Change the Check handler to use `UserCacheConfig::with_config(...)` with
auto input tracking and task-cache directory exclusions, matching the
pattern used by other synthesized commands (build, lint, fmt).
@graphite-app graphite-app bot force-pushed the vp-check-support-cache branch from f257870 to 21c9590 Compare April 8, 2026 02:17
@graphite-app graphite-app bot merged commit 21c9590 into main Apr 8, 2026
37 checks passed
@graphite-app graphite-app bot deleted the vp-check-support-cache branch April 8, 2026 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants