fix: normalize backslashes in env.fish fallback path for Windows/msys (#1953)#1954
fix: normalize backslashes in env.fish fallback path for Windows/msys (#1953)#1954Aalivexy wants to merge 1 commit into
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
There was a problem hiding this comment.
Pull request overview
Fixes Windows/msys-generated env.fish (and other POSIX-like env files) producing backslash-separated paths by normalizing the fallback (non-$HOME-relative) bin path to forward slashes, preventing Fish parse errors when sourcing the file. This change is in the global CLI’s env-file renderer (vp env setup / env file generation), directly addressing issue #1953.
Changes:
- Normalize
bin_path_refto use/separators even when the install dir can’t be expressed as$HOME/...(fallback path case).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b449b8ede2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Aalivexy
force-pushed
the
fix/fish-env-backslash-path-windows
branch
from
b449b8e to
01c496f
Compare
Aalivexy
force-pushed
the
fix/fish-env-backslash-path-windows
branch
from
01c496f to
ca52e74
Compare
Aalivexy
changed the title
Close #1953