fix: skip ingest-reply-assist for cron maintenance tasks#1017
Open
Suidge wants to merge 1 commit intovolcengine:mainfrom
Open
fix: skip ingest-reply-assist for cron maintenance tasks#1017Suidge wants to merge 1 commit intovolcengine:mainfrom
Suidge wants to merge 1 commit intovolcengine:mainfrom
Conversation
Cron maintenance tasks (distillation, weekly synthesis) were being misclassified as transcript-like ingestion and receiving unwanted prompt augmentation. This fix adds pattern detection to identify cron maintenance tasks and skip the ingest-reply-assist injection. Fixes volcengine#982 The fix detects cron tasks by checking for: - [cron:xxx] prefix - 'Daily memory maintenance' / 'Weekly synthesis' phrases - References to distillation/weekly-synthesis instruction files - Workspace: lines
|
Failed to generate code suggestions for PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #982
Cron maintenance tasks (Daily Memory Distillation, Weekly Synthesis) were being misclassified as transcript-like ingestion and receiving unwanted
ingest-reply-assistprompt augmentation.Problem
When running cron maintenance tasks like:
The plugin would:
ingest-reply-assistprompt blockSolution
Added pattern detection in
index.tsto identify cron maintenance tasks and skip theingest-reply-assistinjection. The detection checks for:[cron:xxx]prefixDaily memory maintenance/Weekly synthesisphrasesdistillationorweekly-synthesisinstruction filesWorkspace:linesWhen a cron maintenance task is detected, the plugin logs:
Testing
Verified in production environment:
ingest-reply-assist applied (reason=transcript_like_ingest, speakerTurns=2, chars=452)skipping ingest-reply-assist for cron maintenance taskThe cron tasks now execute correctly without prompt injection.
Changes
examples/openclaw-plugin/index.ts: Added cron maintenance task detection beforeisTranscriptLikeIngest()call