fix(storage): prevent silent data loss in VikingFS.append_file()#1036
Open
RGB-loop wants to merge 1 commit intovolcengine:mainfrom
Open
fix(storage): prevent silent data loss in VikingFS.append_file()#1036RGB-loop wants to merge 1 commit intovolcengine:mainfrom
RGB-loop wants to merge 1 commit intovolcengine:mainfrom
Conversation
When reading existing file content fails (e.g. AGFS timeout, connection error, decryption failure), the broad `except Exception: pass` silently discards the error and sets existing content to empty string. The subsequent write then overwrites the entire file with only the new content, losing all previous data. Only suppress FileNotFoundError (HTTP 404) which is expected on first write. Let other AGFS errors propagate so the caller sees the failure instead of silently losing data.
|
Failed to generate code suggestions for PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VikingFS.append_file()catches all exceptions when reading existing file content and silently falls back to an empty string. This means any transient AGFS failure (timeout, connection error, decryption failure) causes the subsequent write to overwrite the entire file with only the new content — silently losing all previous data.The only caller is
Session._append_to_jsonl(), which appends every message tomessages.jsonl. A single read failure during append wipes the entire message history.Changes
AGFSHTTPErrorwith status 404 (file not found), which is the expected case on first writeAGFSClientError: connection refused, timeout, etc.) propagate to the outer handler which logs and raisesIOErrorTrigger conditions
_decrypt_contentto fail_decode_bytesto raiseTest plan
IOErrorinstead of silently overwriting