fix(openclaw-plugin): resolve sessionKey in memory_store without contextEngineRef#1039
Open
mobilebarn wants to merge 1 commit intovolcengine:mainfrom
Open
fix(openclaw-plugin): resolve sessionKey in memory_store without contextEngineRef#1039mobilebarn wants to merge 1 commit intovolcengine:mainfrom
mobilebarn wants to merge 1 commit intovolcengine:mainfrom
Conversation
…extEngineRef memory_store failed with "Either sessionKey or sessionId is required" when sessionKey was passed but contextEngineRef was null (either because registerContextEngine was unavailable or the factory hadn't been called yet). Fall back to mapSessionKeyToOVSessionId directly so session mapping works regardless of context engine state.
|
Failed to generate code suggestions for PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
memory_storetool throws "Either sessionKey or sessionId is required" even whensessionKeyis passed, because the session mapping depends oncontextEngineRefbeing non-nullcontextEngineRefis null whenregisterContextEngineis unavailable on the OpenClaw API or when the factory hasn't been called yetmapSessionKeyToOVSessionId()so session mapping works regardless of context engine stateTest plan
memory_storewithsessionKeyon an OpenClaw version that does not exposeregisterContextEngine— should succeed instead of rejectingmemory_storewithsessionKeyimmediately after plugin load (before context engine factory is invoked) — should succeedmemory_storewithsessionIdpath unchanged