Skip to content

Fix HTTPX recognition issue with SOCKS5 proxy causing OpenViking crash#1118

Merged
qin-ctx merged 1 commit intovolcengine:mainfrom
wlff123:oc_ov_fix
Mar 31, 2026
Merged

Fix HTTPX recognition issue with SOCKS5 proxy causing OpenViking crash#1118
qin-ctx merged 1 commit intovolcengine:mainfrom
wlff123:oc_ov_fix

Conversation

@wlff123
Copy link
Copy Markdown
Contributor

@wlff123 wlff123 commented Mar 31, 2026

original pr: https://github.com/volcengine/OpenViking/pull/957/changes
Author: wushijian

Description

Related Issue

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update

Changes Made

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this on the following platforms:
    • Linux
    • macOS
    • Windows

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots (if applicable)

Additional Notes

@qin-ctx qin-ctx merged commit c1bd446 into volcengine:main Mar 31, 2026
6 of 10 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenViking project Mar 31, 2026
@github-actions
Copy link
Copy Markdown

Failed to generate code suggestions for PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants