Skip to content

Fixed 'strDelimiter' option in .each and .parse function #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robofish wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed 'strDelimiter' option in .each and .parse function #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
925dcc2
Fixed 'strDelimiter' option not being used in .each and .parse function
robofish Oct 25, 2011
55bbc23
Fixed index.js to work with recent versions of node. process.mixin ha…
robofish Oct 25, 2011
7a878e4
Fixed typo
robofish Oct 25, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
// For your convenience
process.mixin(exports, require('./lib/csv'));
module.exports = require('./lib/csv');
5 changes: 3 additions & 2 deletions lib/csv.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ exports.each = function (filename, options) {
var stream = new events.EventEmitter();

var emit_row = function(row) {
var data = CSVToArray(row)[0];
var data = CSVToArray(row, strDelimiter)[0];
if (options["headers"]) {
if (headers == null) {
headers = data;
Expand Down Expand Up @@ -181,13 +181,14 @@ exports.parse = function(str, options, data_listener) {
throw new Exception("Data listener must be provided");
}
options = (options || {});
var strDelimiter = (options.strDelimiter || ",");
var stream = new events.EventEmitter();
stream.addListener("data", data_listener);
var parts = str.split("\n");
var pl = parts.length;
var headers = null;
for( var i = 0; i < pl; i++) {
var data = CSVToArray(parts[i])[0];
var data = CSVToArray(parts[i], strDelimiter)[0];
if (options["headers"]) {
if (headers == null) {
headers = data;
Expand Down