Add container to props#14
Open
septagram wants to merge 1 commit into
Open
Conversation
Setting `container` to `true` will render Pikaday directly instead of managing an input field. Passing a ref to another React component or a DOM node directly should also work as expected, but was not tested.
|
I had some issues with this commit and made fixes for the calendar hiding upon entering a date as well as passing a ref to another React component. Not sure how to add those changes to this commit but they're at https://github.com/mikhuang/react-pikaday-component/tree/feature/container |
voronianski
requested changes
Jul 26, 2017
|
|
||
| this.pikaday = new Pikaday(options); | ||
|
|
||
| if (container === true) { |
|
|
||
| const options = Object.assign({}, pikadayOptions, { | ||
| field: el, | ||
| container: container === true ? this.refs.pikadayContainer : |
| const options = Object.assign({}, pikadayOptions, { | ||
| field: el, | ||
| container: container === true ? this.refs.pikadayContainer : | ||
| container && container.getDOMNode ? container.getDOMNode() : container, |
Owner
There was a problem hiding this comment.
it's not possible to get into this case because of container === true will always use this.refs.pikadayContainer...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
containertotruewill render Pikaday directly instead ofmanaging an input field. Passing a ref to another React component or a DOM
node directly should also work as expected, but was not tested.