Skip to content

critical indexing fix for annular PCA-ASDI#711

Merged
VChristiaens merged 1 commit intovortex-exoplanet:masterfrom
IainHammond:master
Apr 14, 2026
Merged

critical indexing fix for annular PCA-ASDI#711
VChristiaens merged 1 commit intovortex-exoplanet:masterfrom
IainHammond:master

Conversation

@IainHammond
Copy link
Copy Markdown
Contributor

fixed an indexing mistake for 4D cubes (the wavelength axis was indexed instead of the temporal axis)

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 14, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 50.28%. Comparing base (72fa44e) to head (38413c5).
⚠️ Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
src/vip_hci/psfsub/pca_local.py 0.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #711       +/-   ##
===========================================
+ Coverage   28.47%   50.28%   +21.81%     
===========================================
  Files          88       88               
  Lines       17048    17058       +10     
===========================================
+ Hits         4854     8578     +3724     
+ Misses      12194     8480     -3714     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@VChristiaens
Copy link
Copy Markdown
Contributor

Thanks for catching this @IainHammond !

@VChristiaens VChristiaens merged commit 3b2074d into vortex-exoplanet:master Apr 14, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants