Improve error handling for DNS timeouts and clean terminal output#50
Open
mrvcode wants to merge 1 commit intovortexau:masterfrom
Open
Improve error handling for DNS timeouts and clean terminal output#50mrvcode wants to merge 1 commit intovortexau:masterfrom
mrvcode wants to merge 1 commit intovortexau:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Hi! I've noticed that when a nameserver fails to respond (e.g., due to a firewall or connection timeout), the tool sometimes masks the error or displays a generic poisoning message.
I have updated dnsvalidator.py to:
Capture specific connection errors: It now displays the actual exception (like 'Resolution lifetime expired') instead of just failing.
Clean up output: Removed redundant strings from the dnspython exceptions to keep the terminal logs readable.
This change helps security researchers distinguish between a truly malicious DNS response and simple network connectivity issues during large scans."