Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@ All notable changes to vouch are documented here. Format follows

## [Unreleased]

### Fixed
- `compile_kb()` no longer lets two same-titled drafts in one LLM batch both
survive validation — the second collided with the first on approval and
silently overwrote it via the `update_page` vault-edit path. accepted
titles are now folded into `taken_names` as soon as they survive, so a
same-batch duplicate is dropped just like a collision with an existing
page or pending proposal.

## [1.2.2] — 2026-07-07

### Packaging
Expand Down
5 changes: 5 additions & 0 deletions src/vouch/compile.py
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,11 @@ def compile_kb(
report.dropped.append({"title": title, "reason": problem})
continue
survivors.append((draft, title))
# fold the accepted title into taken_names immediately: a later draft
# in this same batch colliding with it must be dropped too, mirroring
# how phase 2 folds survivors back in for wikilink resolution below.
taken_names.add(title.lower())
taken_names.add(_slugify(title))

# phase 2: wikilinks resolve against existing pages + the *surviving*
# batch, to a fixpoint — dropping a draft may dangle a link in another,
Expand Down
21 changes: 21 additions & 0 deletions tests/test_compile.py
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,27 @@ def test_collision_with_pending_proposal_dropped(
assert "pending review" in second.dropped[0]["reason"]


def test_same_batch_duplicate_titles_second_dropped(
store: KBStore, tmp_path: Path,
) -> None:
"""Two same-titled drafts in one compile_kb() call must not both survive
validation — the second would collide with the first on approval and
silently overwrite it via the update_page vault-edit path (#439)."""
c1 = _approved_claim(store, "a fact")
report = compile_kb(store, config=_cfg(_stub_llm(tmp_path, [
{"title": "Deploy Workflow", "type": "workflow",
"body": f"first body [claim: {c1}]", "claims": [c1]},
{"title": "Deploy Workflow", "type": "workflow",
"body": f"SECOND BODY totally different [claim: {c1}]",
"claims": [c1]},
])))
assert len(report.proposed) == 1
assert "already exists" in report.dropped[0]["reason"]

approve(store, report.proposed[0]["proposal_id"], approved_by="human-B")
assert store.get_page("deploy-workflow").body == f"first body [claim: {c1}]"


def test_dropped_sibling_dangles_wikilink_and_cascades(
store: KBStore, tmp_path: Path,
) -> None:
Expand Down