feat(goals): add review-gated first-class goals#444
Conversation
model goals as durable reviewed artifacts with propose/list/status surfaces across cli, mcp, and jsonl. this keeps in-flight objectives queryable, audit-logged, and visible in session-start recall without bypassing the review gate. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reached
Next review available in: 44 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (16)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closes #427
What changed
added first-class, review-gated goals across the stack. this introduces a new
Goalartifact andGoalStatusenum in the model layer, persists approved goals under.vouch/goals/, extends proposal handling withpropose_goal, and wires goal support into approval/lifecycle/audit paths. the public surfaces now includekb.propose_goal,kb.list_goals, andkb.goal_set_statuson mcp/jsonl/capabilities, plus matching cli commands (vouch propose-goal,vouch list-goals,vouch goal-status) and avouch digestalias. recall now includes open goals, and bundle/sync/health checks were updated to understand goal artifacts. tests were added/updated intests/test_goals.py,tests/test_recall.py, andtests/test_storage.py.Why
this implements #427 so vouch can represent in-flight intent as reviewed, queryable knowledge instead of burying objectives in freeform session text. goals now follow the same review gate and audit guarantees as other writes, enabling agents and operators to recover active objectives (
opengoals) at session start while keeping status transitions explicit and traceable.What might break
this is a surface expansion and introduces a new on-disk artifact directory (
.vouch/goals/) plus newkb.*methods (kb.propose_goal,kb.list_goals,kb.goal_set_status). existing claim/page/entity/relation flows are unchanged. tooling that assumes only four proposal kinds may need updates to handlegoal.VEP
surface change. if a vep is required for this scope, please link it here before merge.
Tests
make checkpasses locally (lint + mypy + pytest)CHANGELOG.mdupdated under## [Unreleased]