Skip to content

feat(goals): add review-gated first-class goals#444

Open
dale053 wants to merge 2 commits into
vouchdev:mainfrom
dale053:feat/427-first-class-goals
Open

feat(goals): add review-gated first-class goals#444
dale053 wants to merge 2 commits into
vouchdev:mainfrom
dale053:feat/427-first-class-goals

Conversation

@dale053

@dale053 dale053 commented Jul 8, 2026

Copy link
Copy Markdown

Closes #427

What changed

added first-class, review-gated goals across the stack. this introduces a new Goal artifact and GoalStatus enum in the model layer, persists approved goals under .vouch/goals/, extends proposal handling with propose_goal, and wires goal support into approval/lifecycle/audit paths. the public surfaces now include kb.propose_goal, kb.list_goals, and kb.goal_set_status on mcp/jsonl/capabilities, plus matching cli commands (vouch propose-goal, vouch list-goals, vouch goal-status) and a vouch digest alias. recall now includes open goals, and bundle/sync/health checks were updated to understand goal artifacts. tests were added/updated in tests/test_goals.py, tests/test_recall.py, and tests/test_storage.py.

Why

this implements #427 so vouch can represent in-flight intent as reviewed, queryable knowledge instead of burying objectives in freeform session text. goals now follow the same review gate and audit guarantees as other writes, enabling agents and operators to recover active objectives (open goals) at session start while keeping status transitions explicit and traceable.

What might break

this is a surface expansion and introduces a new on-disk artifact directory (.vouch/goals/) plus new kb.* methods (kb.propose_goal, kb.list_goals, kb.goal_set_status). existing claim/page/entity/relation flows are unchanged. tooling that assumes only four proposal kinds may need updates to handle goal.

VEP

surface change. if a vep is required for this scope, please link it here before merge.

Tests

  • make check passes locally (lint + mypy + pytest)
  • New / changed behaviour has a test
  • CHANGELOG.md updated under ## [Unreleased]

model goals as durable reviewed artifacts with propose/list/status surfaces across cli, mcp, and jsonl. this keeps in-flight objectives queryable, audit-logged, and visible in session-start recall without bypassing the review gate.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@dale053, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 44 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b8f0bce6-0632-4b1e-92a9-f17e8734b414

📥 Commits

Reviewing files that changed from the base of the PR and between 5c98a3a and 2435cf4.

📒 Files selected for processing (16)
  • CHANGELOG.md
  • src/vouch/bundle.py
  • src/vouch/capabilities.py
  • src/vouch/cli.py
  • src/vouch/health.py
  • src/vouch/jsonl_server.py
  • src/vouch/lifecycle.py
  • src/vouch/models.py
  • src/vouch/proposals.py
  • src/vouch/recall.py
  • src/vouch/server.py
  • src/vouch/storage.py
  • src/vouch/sync.py
  • tests/test_goals.py
  • tests/test_recall.py
  • tests/test_storage.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added docs documentation, specs, examples, and repo guidance cli command line interface mcp mcp, jsonl, and http surfaces storage kb storage, migrations, schemas, and proposals sync sync, vault mirror, and diff flows tests tests and fixtures size: L 500-999 changed non-doc lines labels Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli command line interface docs documentation, specs, examples, and repo guidance mcp mcp, jsonl, and http surfaces size: L 500-999 changed non-doc lines storage kb storage, migrations, schemas, and proposals sync sync, vault mirror, and diff flows tests tests and fixtures

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: first-class goals — review-gated in-flight objectives

1 participant