VOUCHEDSEC-4941 Adding example of how to allow links in the webview#6
Draft
mmachado53 wants to merge 1 commit intomainfrom
Draft
VOUCHEDSEC-4941 Adding example of how to allow links in the webview#6mmachado53 wants to merge 1 commit intomainfrom
mmachado53 wants to merge 1 commit intomainfrom
Conversation
Contributor
|
So code looks fine, but we really should document the behavior when you use weblinks. At a minimum, let's add a comment about this behavior in the code, so it is clear to the devloper that there is a side effect in uncommenting the code, Still hope there's a workaround for this behavior. |
Contributor
Author
|
@JayLVouched well, this is the default behavior (the same in a webview in RN), I think I like this more than adding the code to handle the links SVID_20221208_121218_1.mp4 |
Contributor
|
Funny, I like no code. We should show that to Orian. I don't think iOS acts
that way, but I'll check.
…On Thu, Dec 8, 2022 at 11:15 AM Miguel Machado ***@***.***> wrote:
@JayLVouched <https://github.com/JayLVouched> well, this is the default
behavior (the same in a webview in RN), I think I like this more than
adding the code to handle the links
https://user-images.githubusercontent.com/1523737/206546562-e2ac5520-ecc8-4d7a-bb7e-c1fa85f76952.mp4
—
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AV2CGAYYZTYERVM6QRJF77DWMIXULANCNFSM6AAAAAASWHBRRM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Closing since this is stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added that example but there is a problem, as you can see in the following video, the plugin reloads when you go back, I have searched how to solve that but I still can't find the way.
SVID_20221206_185704_1.mp4