Move the import of langchain_text_splitters into chunking.default_chunk_fn#37
Open
jun76 wants to merge 1 commit intovoyage-ai:mainfrom
Open
Move the import of langchain_text_splitters into chunking.default_chunk_fn#37jun76 wants to merge 1 commit intovoyage-ai:mainfrom
jun76 wants to merge 1 commit intovoyage-ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Background
Thank you for your continued support.
I noticed that simply
import voyageaiin my project causespython -X importtimeto take about 5 seconds.Upon investigating the cause, I discovered that
langchain_text_splitters, loaded in the global scope of voyageai/chunking.py, finds and imports heavy dependencies within my project, such as sentence-transformers, torch, transformers, and scipy.Therefore, I would greatly appreciate it if
langchain_text_splitterscould be deferred. I have submitted this PR accordingly.Thank you.
Pytest
The following has been verified to pass.